[PEPr] Comment on Images::Thumbnail
| From: | Alan Knowles | Date: | Tue, 26 Apr 2005 15:16:13 +0000 |
| Subject: | [PEPr] Comment on Images::Thumbnail | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-37413@lists.php.net to get a copy of this message | ||
Alan Knowles (http://pear.php.net/user/alan_k) has commented on the proposal for Images::Thumbnail.
Comment:
I think this should probably use image_transform as a backend (perhaps with
the addition of the exif test.)
- which will remove most of the code.
The code needs a few of CS fixes (especially phpdoc comments).
The api could be alot simpler:
::factory / contruct( $options )
::generate($dir);
::getCachedFileName([$with_path]);
::getMimeType(); ??? although file etc. would do this..
I'm not sure it should be the libraries responsibility to send headers or
even the image..
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=242
--
Sent by PEPr, the automatic proposal system at http://pear.php.net