Re: [PEPr] Comment on HTML::HTML_QuickForm_advmultiselect

Laurent Laville wrote:

I don't think follows very well your mind way. What you expected to have : 1. an alternate way for browser that have js disabled ? 2. another way to manage both lists ? you wrote : " ... Client-side JS switch visibility for the select elements. ..." Please explains me , i've some doubt !

I mean to support JS-impaired web clients... From the implementation point of view, why not doing a "select all" of the selected items just before the form is submitted? I maybe missing something, but it doesn't seem simple to capture both selected and unselected, but these terms are actually missleading. Basically, you want to split a list into two lists. One may be interested into the two lists. The implementation also doesn't seem to leave much room to more than 2 select lists. What if you want to split a list of items into 3 select boxes...? Otherwise, I think there could be a need for "Add All" and "Remove All" buttonsBy the way, it should be ' selected="selected"' around line 277 Any special reasons why you don't use the str_replace(array(), array(), text) syntax, instead of the multiple successive str_replace(string, string, text) calls (around lines 317 and 329)? -Philippe