Re: [PEPr] Changes in proposal for File Formats::File_Fortune

Matthew Weier O'Phinney wrote: > Matthew Weier O'Phinney (http://pear.php.net/user/weierophinney) has edited the proposal > for File Formats::File_Fortune. > > Change comment: > > I've reverted to a PHP5-only version. Additionally, I have moved the bulk > of the package-level documentation blocks to the class-level docblocks as > they contain information on class usage (this allows this info to show up > in the generated documentation). > > > > I have moved the error constants into the classes themselves, which also > allowed me to strip the classname prefix; all thrown errors were modified > to utilize the new class constants. > > Please review the proposal: > http://pear.php.net/pepr/pepr-proposal-show.php?id=263 > For a PHP5-only package, you should use exceptions, not return-value errors. That is not to say you should drop error constants, but for PHP5 Exceptions are the error returning method agreed upon: Guidelines are here: http://pear.php.net/pepr/pepr-proposal-show.php?id=132 Cheers, -- Sérgio