Re: [PEPr] Comment on File Formats::File_Fortune
| From: | Matthew Weier O'Phinney | Date: | Sun, 03 Jul 2005 03:45:14 +0000 |
| Subject: | Re: [PEPr] Comment on File Formats::File_Fortune | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-38424@lists.php.net to get a copy of this message | ||
On 1 Jul 2005 11:03:42 -0000, Alan Knowles <alan@akbkhome.com> wrote:
>
> Alan Knowles (http://pear.php.net/user/alan_k) has commented on the proposal
> for File Formats::File_Fortune.
>
> Comment:
>
> looks ok - apart from a few minor CS things,
>
> - a few short if's , and using dirname(__FILE__) in the require stmt..
I've addressed the above in the latest release listed on the proposal.
--
Matthew Weier O'Phinney
mweierophinney@gmail.com
http://weierophinney.net/matthew/