[PEPr] Comment on Images::Image_Canvas
| From: | Jesper Veggerby | Date: | Wed, 20 Jul 2005 20:48:11 +0000 |
| Subject: | [PEPr] Comment on Images::Image_Canvas | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-38812@lists.php.net to get a copy of this message | ||
Jesper Veggerby (http://pear.php.net/user/nosey) has commented on the proposal for
Images::Image_Canvas.
Comment:
Toby:
If changing write() and done() means a +1 from you, then it's fine with me
:)
Regarding your wish for arrays as parameters, I see the best/only use for
them when having need for overloads.
Especially when having to document these arrays I find them a pain, but
also having to write the extra (seemingly uncessary) array(..) bothers me,
and even worse if it's "hashed".
But of course it offers greater flexibility, but at the high price of
"clearness-of-code" (you can't just take the header of the method and
understand the parameters)
However (after this looong speak against :)), in many methods (factory,
done, setFont, etc), I already employ the use of associated arrays, so for
the sake of consistency in the package I agree on your point and I will
change them.
/Jesper
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=212
--
Sent by PEPr, the automatic proposal system at http://pear.php.net