Re: [PEPr] Comment on Images::Image_Canvas

Hi Toby

Having both possibilities in place seems a good idea. Don't you agree?

To some extent: yes. I cas see 2 advantages and 3 disadvantages to this: adv. 1) You can do it the way you want => more user friendly adv. 2) It's perhaps better than just having the array, since documentation is easier. Describe the parameters, and then state that BTW you can wrap all these up in a single hashed array disadv. 1) It's more error prone, since you have to remember to include the parameter in two different places disadv. 2) It causes some more overhead, having to check if it's an array and then "pull" the values from the array - I know it's probably not much, but if we all do this and have many method calls, then it causes an seemingly unecessary overhead. disadv. 3) It causes inconsistencies (at least for this package), since some method can only be used with the array, such as the done() and factory() method, so when do the user know when to do what?! (I know it's already like this in the package, which is why I take your point and want to change it). So again I think for consistency: the one or the other (whenever possible) But are there any other opinions? regards Jesper