[PEPr] Comment on HTML::HTML_FlashTag
| From: | bertrand Gugger | Date: | Wed, 27 Jul 2005 23:05:42 +0000 |
| Subject: | [PEPr] Comment on HTML::HTML_FlashTag | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-38989@lists.php.net to get a copy of this message | ||
bertrand Gugger (http://pear.php.net/user/toggg) has commented on the proposal for
HTML::HTML_FlashTag.
Comment:
Nice coding, anyway I wonder if the constructor should not better use an
associative array, as it was debated recently on dev-list ... by 7
arguments, that becomes difficult to maintain.
The default values for the parameters $objectAttributes and
$paramAttributes should be array() certainly and not null ... or don't use
them as array in this case.
Same note as HTML_Tag: ($this->alternateContent != null) is false if '' or
0, use !== to avoid a casting.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=277
--
Sent by PEPr, the automatic proposal system at http://pear.php.net