[PEPr] Comment on HTML::HTML_FlashTag

Xavier Baldacci (http://pear.php.net/user/balda) has commented on the proposal for HTML::HTML_FlashTag. Comment: The code was corrected : - default values of $objectAttributes and $paramAttributes are now array(). - the "$content" test is rectified. About the attributes of the constructor, you generaly only need to use 3 of them (or 4 if you want an alternate content, or embed tags). I can put the $_is_valid attribute in the third position. Then, you only need 2 attributes in the constructor (for valid html, without alternate). But your argument of maintenance is good : i can easily adapt the code (i find the idea of associative arrays interesting). Maybe like that : HTML_FlashTag($objectAttributes, $paramAttributes, $arrayOfOptions); Keys for $arrayOfOptions : $_is_valid, $alternateContent, $flashVersion, $is_xhtml, $tabOffset. What do you think about that ? Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=277 -- Sent by PEPr, the automatic proposal system at http://pear.php.net