[PEPr] Comment on HTML::HTML_FlashEmbed
| From: | Ian Eure | Date: | Mon, 25 Jul 2005 18:15:48 +0000 |
| Subject: | [PEPr] Comment on HTML::HTML_FlashEmbed | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-38876@lists.php.net to get a copy of this message | ||
Ian Eure (http://pear.php.net/user/ieure) has commented on the proposal for HTML::HTML_FlashEmbed.
Comment:
Much better, but there are still problems:
- Still have the disconnect between HTML_Common and HTML_FlashEmbed wrt.
the generated elements. This is bad design, and is a showstopper IMO. It
makes it impossible to put different values in the same attribute on
different elements, e.g. you can't set class or id of 'object' to be
different from that of 'embed' - in fact, with your attr whitelist
approach, you can't set class or id at all. You also can't set additional
param tags for the flash file.
- $flashVersion isn't an actual version (i.e. "7.0") - seems a bit weird,
you should be able to take a double as an argument and generate the
four-digit-with-comma format that's needed for the markup from it.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=277
--
Sent by PEPr, the automatic proposal system at http://pear.php.net