Re: New draft: Google_Map

On Friday 09 September 2005 05:58 am, Markus Tacker wrote: > Hoi all, > > I just added Google_Map [1] as draft. I'd be glad to hear your thoughs > about it especially what you think about wrapping a JavaScript API inside > PHP. > I like it a lot. - You need to use the new header comment blocks. - You should stick to toHtml() and display() methods, like other packages which output HTML. I don't see any need at all for getHTMLDocument(). - Why is $html an array in getHTML()? Is there something wrong with string concatenation? - You should follow the XHTML compatibility guidelines; you currently don't have a space in between the / and > in your br tags. - Escaping of the JavaScript is insufficient. For HTML & XHTML compatibility, it needs to be: <script type="text/javascript"><!--//--><![CDATA[//><!-- ... //--><!]]></script> - You should autogenerate an ID for the map element, or allow one to be specified. Using one ID means you can only have one map per page, which I see as being a potential issue. - Any chance of fixing this so it works on PHP 4.x as well? The only 5.x-specific things you appear to be using are Exceptions, which could be trivially reimplemented.

Attachment: [application/pgp-signature]