Re: New draft: Google_Map

Hoi all, thanks a lot for your comments. I'll reply to Ian's mail and answer all the topics below. As I am three and a half weeks on holiday starting from wednesday so I scheduled the proposol for 22-10-2005. I would be glad if someone is interested in co-maintaining the package. Ian Eure wrote:

- You need to use the new header comment blocks.

Ok. I didn't notice that proposal.

- You should stick to toHtml() and display() methods, like other packages which output HTML. I don't see any need at all for getHTMLDocument().

Ok. I think that's usefull. For fetching the body part only there is already Google_Map::toHTML() which includes the JavaScript and the map container. So display() will create the whole page and toHTML() will return only the HTML and JavaScript for the map.

- Why is $html an array in getHTML()? Is there something wrong with string concatenation?

Noting, I just don't like the . "\n"; at the end. But I'll change that.

- You should follow the XHTML compatibility guidelines; you currently don't have a space in between the / and > in your br tags. - Escaping of the JavaScript is insufficient. For HTML & XHTML compatibility, it needs to be:

Ok, that'll be fixed too.

- You should autogenerate an ID for the map element, or allow one to be specified. Using one ID means you can only have one map per page, which I see as being a potential issue.

Good Idea. I'll also add a property for the div's class name.

- Any chance of fixing this so it works on PHP 4.x as well? The only 5.x-specific things you appear to be using are Exceptions, which could be trivially reimplemented.

I agree to Matthew. I think PHP5 is finally widely accepted even with mass hosters. But your right by saying that exceptions do not justify the use of PHP5. I am going to support PHP4 also. -- mit freundlichen Grüßen | Jabber: m@tacker.org m.tacker | ICQ: 9170 9561

Attachment: [application/x-pkcs7-signature] S/MIME Cryptographic Signature smime.p7s