Re: New draft: Google_Map
| From: | Philippe Jausions | Date: | Mon, 12 Sep 2005 19:14:48 +0000 |
| Subject: | Re: New draft: Google_Map | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-39801@lists.php.net to get a copy of this message | ||
Markus,
I'd like to see some sanity check on the values of addMarker() such as type casting $longitude and $latitude...
Also, why, oh why, using sprintf()???
I would use multiline text values instead of all the $html .= ''... lines.
$html = 'line 1
line 2
line3';
But that could "mess" up the indentation of the script. Not sure of the PEAR CS stand on that... all the concatenations seem a bit of waste of CPU to me.
There should also have a big warning of potential of HTML code injections...
-Philippe
Markus Tacker wrote:
Hoi all, I just added Google_Map [1] as draft. I'd be glad to hear your thoughs about it especially what you think about wrapping a JavaScript API inside PHP. [1] http://pear.php.net/pepr/pepr-proposal-show.php?id=298