[PEPr] +1 for Web Services::Services_JSON

From: Date: Fri, 14 Oct 2005 17:41:47 +0000
Subject: [PEPr] +1 for Web Services::Services_JSON
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-40194@lists.php.net to get a copy of this message
Justin Patrin (http://pear.php.net/user/justinpatrin) has voted +1 on the proposal for Web Services::Services_JSON. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=198 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=198&handle=justinpatrin This vote is conditional. The condition is: Constant names must conform to CS (the entire package name shoudl be used). I also don't really like Services_JSON but I'm not sure where else this would go.. There should be spaces around all operators (such as = in the constructor and += later in the code). enc() and dec() should be removed. They don't actually add anything and will only help to confuse things. There is still "(backslash)(backslash)" in the code. Please use a single quoted string (for consistency). Docblock class names need to be updated (I see JSON::decode, but it should be Setvices_JSON::decode or whatever name is eventually chosen). Thanks for taking into account my previous comments. -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#40194) next »