[PEPr] Comment on PEAR::PEAR_PackageUpdate

Laurent Laville (http://pear.php.net/user/farell) has commented on the proposal for PEAR::PEAR_PackageUpdate. Comment: My first comment, is only related to source code and PHP dependency. A quick parse of source code with PHP_CompatInfo gave PHP 5.0.0 min but this result is not significant. So i've also tried with script : <?php require_once 'PEAR/Common.php'; $c = new PEAR_Common(); $file = '[...]PEAR\PackageUpdate.php'; $res = $c->analyzeSourceCode($file); ?> And found unexpected public tokens on lines : 538: public function setDontAskAgain($dontAsk) 555: public function setDontAskUntilNextRelease($nextrelease) 580: public function setMinimumRleaseType($minType) 602: public function setMinimumState($minState) 629: public function setPreference($pref, $value) { Need to fix it or this package is only for PEAR 2 and PHP 5.x ;-) Even Greg told us that PEAR 1.5.0 will have PHP 4.3.0 min. Laurent Laville Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=369 -- Sent by PEPr, the automatic proposal system at http://pear.php.net