[PEPr] Comment on PEAR::PEAR_PackageUpdate

Justin Patrin (http://pear.php.net/user/justinpatrin) has commented on the proposal for PEAR::PEAR_PackageUpdate. Comment: I would suggest using PEAR_ErrorStack instead of implementing your own error stack in the class. I'm also not sure why you're not returning a PEAR_Error. I don't see any loops in the class itself so it doesn't make sense for it to simply aggregate its errors. The package should return PEAR::raiseError on error and let the calling package decide if it wants to aggregate or not. As has been said before, instanceOf is PHP5 only. If this is a PHP4 package (as it seems to be) please use is_a. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=369 -- Sent by PEPr, the automatic proposal system at http://pear.php.net