Re: [PEPr] +1 for Database::DB_eXist

Just a quick thought. eXist is an XML database, why not name it XML_eXistDB or simply eXistDB? That should avoid the confusion w/ this being possibly a driver for PEAR::DB --- Justin Patrin <papercrane@reversefold.com> wrote: > > Justin Patrin (http://pear.php.net/user/justinpatrin) has voted +1 on the > proposal for Database::DB_eXist. > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=303 > Vote information: > > http://pear.php.net/pepr/pepr-vote-show.php?id=303&handle=justinpatrin > > This vote is conditional. The condition is: > > I don't really like that this is named DB_eXist. People could easily think > that this is a driver for the DB package. Then again, I can think of no > better alternatives right now. > > Why use defines for the output modes? Why not just use the straight strings? > The strings are far shorter than the defines. > > PEAR packages shouldn't be checking for PHP version runtime, the installer > takes care of this. (In addition, defining it right before you use it is > pretty worthless.) > > PEAR packages may not die(). > > Classnames are incorrect. See the naming documents. Drivers should probably > be e.g. DB_Exist_Driver and the class file must be DB/Exist/Driver.php. > > Don't use paths relative to __FILE__ to include files, includ relative to the > PEAR install dir (i.e. from the include_path). > > Use lower-case null. > > It would make more sense to me to allow the WSDL URLs to be set in the > constructor. > > Exceptions thrown must be a sub-class of PEAR_Exception nammed after your > package. So DB_Exist_Exception. > > is_readable() does not take into account the include_path so you can't use it > as-is. I suggest something like the includeClass function in this class: > http://pear.reversefold.com/FormBuilder2/FormBuilder2.php > > -- > Sent by PEPr, the automatic proposal system at _
çDÏ–ù > øõÿçhttp://pear.php.net > > -- > PEAR Development Mailing List (http://pear.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Jesus M. Castagnetto (jcastagnetto@yahoo.com) Web site: http://www.castagnetto.org/ Research: http://metallo.scripps.edu/ PEAR stuff: http://pear.php.net/user/jmcastagnetto __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com