Re: [PEPr] Proposal for Database::DB_eXist

Hi Benjamin If you don't mind, could you please move "require_once 'XML/DB/eXist/driver.iface.php';" from exists.php into soap.class.php before the class definition? public function connect($username = 'guest', $password = 'guest'); that simply is, IMHO, bad practice. Demanding that all drivers declare default username and password is IMO absurd. soap.driver.php public function __construct($options) {

       if(isset($options['wsdl']) || isset($options['wsdlAdmin'])) {
           $this->setWSDL($options['wsdl'], $options['wsdlAdmin']);
       }

} That will throw notice if either of them aren't set. Is it possible to return true/false in connect()? Seems weird that it doesn't return anything... Mind changing default values from empty string to null? And at last, the exception 'Driver class has to inherit XML_DB_eXist_Interface' is incorrect, it has to implement, not inherit, the interface. -Hannes On 5/25/06, Benjamin Muskalla <b.muskalla@gmx.net> wrote:

Hi list, hi voters I've put a new version of "XML_DB_eXist" online. Here is the changelog:

            * Renamed to XML_DB_eXist
            * Removed PHP version check
            * Replaced upper-case NULL with lower-case null
            * Throws XML_DB_eXist_Exceptions instead of Exceptions
            * Removed extension check
            * Added parameter $options to pass wsdl and wsdlAdmin (only

soap driver) to the singleton

            * Added static functions factory() and singleton() as

aliases to getInstance()

            * Removed brackets in include/require statements
            * Interface is now required, not included
            * Trimmed down the code to 80 chars per line

You can get more information about it on http://www.bmuskalla.de/DB_eXist The PEAR-Package: http://bmuskalla.de/DB_eXist/files/XML_DB_eXist-0.5.0.tgz Sourcecode can be found here: http://www.bmuskalla.de/DB_eXist/source/ And the docs here: http://www.bmuskalla.de/DB_eXist/docs/ I hope this is the way to get into PEAR :) Greets Benjamin