Re: Re: [ANNOUNCEMENT] Structures_DataGrid-0.7.0 (beta) Released.
| From: | Joe Stump | Date: | Mon, 19 Jun 2006 18:21:11 +0000 |
| Subject: | Re: Re: [ANNOUNCEMENT] Structures_DataGrid-0.7.0 (beta) Released. | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.pear.dev php.pear.qa |
| Request: | Send a blank email to pear-dev+get-43014@lists.php.net to get a copy of this message | ||
I completely disagree with this. You're basically advocating code duplication. What should happen is one of the following:
1.) Optional dependency (noted in the docs)
2.) Up your PHP requirements
3.) Let people running old versions of PHP install PHP_Compat on their own
Copying and pasting code from one package to another should be discouraged IMO.
--Joe
On Jun 19, 2006, at 11:14 AM, Pierre wrote:
On 6/19/06, Olivier Guilyardi <ojaiml@nerim.net> wrote:Pierre wrote:No, as we defined than a package cannot depend on php_compat. Especially not when you are in beta. It makes no sense.Structures_DataGrid,I've included the function we need directly intoand am removing the dependency completely.I said that I "included" the function, that is : I made a function named "Structures_DataGrid_http_build_query()", and am not using PHP_Compat's http_build_query() anymore.That's fine and even better, in my oppinion. That's what php_compat should be, a copy/paste package (in most cases) :-) --Pierre --PEAR QA Mailing List (http://pear.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php