Re: Re: [ANNOUNCEMENT]Structures_DataGrid-0.7.0 (beta) Released.

Greg Beaver wrote:

Olivier Guilyardi wrote:

I said that I "included" the function, that is : I made a function named "Structures_DataGrid_http_build_query()", and am not using PHP_Compat's http_build_query() anymore. Is there anything wrong with this ? (I'm not sure what you were talking about in the above citation)

I'd say a good rule of thumb is if you only need about 30 lines of code or so, and it isn't too complex (i.e. you can maintain it, and the chance of a bug is low), cut-and-paste is usually better than a dependency.

That's 60 lines in our case. But, I would have liked : - a conditional dependency, to do : if php < 5 then require php_compat - or "pear package-validate" to detect that php_compat was required, and issue an error

Anything that introduces more than 1 function, more than 30 lines of code (approximately) or a very complex algorithm is probably best used as a dependency. Of course, there are gray areas, and we have to recognize them. Preferrably with calm and clear-headedness.

Yes, that's only 1 function here. I was calm although the situation was stressful, because we've worked several months for this release. But I think it went fine. -- og