Re: Re: [ANNOUNCEMENT]Structures_DataGrid-0.7.0 (beta) Released.

Olivier Guilyardi wrote: > Pierre wrote: > >>> I've included the function we need directly into Structures_DataGrid, >>> and am >>> removing the dependency completely. >> >> >> No, as we defined than a package cannot depend on php_compat. >> Especially not when you are in beta. It makes no sense. > > > I said that I "included" the function, that is : I made a function named > "Structures_DataGrid_http_build_query()", and am not using PHP_Compat's > http_build_query() anymore. > > Is there anything wrong with this ? (I'm not sure what you were talking > about in the above citation) I'd say a good rule of thumb is if you only need about 30 lines of code or so, and it isn't too complex (i.e. you can maintain it, and the chance of a bug is low), cut-and-paste is usually better than a dependency. Anything that introduces more than 1 function, more than 30 lines of code (approximately) or a very complex algorithm is probably best used as a dependency. Of course, there are gray areas, and we have to recognize them. Preferrably with calm and clear-headedness. Greg