Re: Re: [ANNOUNCEMENT] Structures_DataGrid-0.7.0 (beta) Released.
| From: | Pierre | Date: | Mon, 19 Jun 2006 18:33:00 +0000 |
| Subject: | Re: Re: [ANNOUNCEMENT] Structures_DataGrid-0.7.0 (beta) Released. | ||
| References: | 1 2 3 4 5 6 7 8 9 10 | Groups: | php.pear.dev php.pear.qa |
| Request: | Send a blank email to pear-dev+get-43015@lists.php.net to get a copy of this message | ||
On 6/19/06, Joe Stump <joe@joestump.net> wrote:
I completely disagree with this. You're basically advocating code duplication. What should happen is one of the following:You are (again) putting words in my mouth. I never said that duplicating code is good. But in the case of php_compat, it is. That's all.
1.) Optional dependency (noted in the docs)Read the full thread, this solution was rejected.
2.) Up your PHP requirementsAgain
3.) Let people running old versions of PHP install PHP_Compat on their ownPlease check the lists archive.
Copying and pasting code from one package to another should be discouraged IMO.It is, in 99.99%. But nothing is black and white, there is a gray area, sometimes small. This case is in the gray area and I think it is a perfectly and sane choice to duplicate this portion of code. Cheers, --Pierre