[PEPr] -1 for Math::BigInteger
| From: | Joe Stump | Date: | Tue, 27 Jun 2006 18:35:28 +0000 |
| Subject: | [PEPr] -1 for Math::BigInteger | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-43149@lists.php.net to get a copy of this message | ||
Joe Stump (http://pear.php.net/user/jstump) has voted -1 on the proposal for Math::BigInteger.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=407
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=407&handle=jstump
Comment:
All sorts of CS problems. The class name should be Math_BigInteger, all of
the defines should be MATH_BIGINTEGER_FOO, etc.The documentation, while
thorough, needs to be in the phpDocumentor format. Also, the header isn't
the required PEAR header.
The bcpowmod function you define should either be a part of PHPCompat (ie.
your package requires PHPCompat, which implements this function) or you
should put that if statement into your class definition.
Ideally, your class would use the native BC functions if they existed as
well.
--
Sent by PEPr, the automatic proposal system at http://pear.php.net