Re: [PEPr] -1 for Math::BigInteger

Hello,

All sorts of CS problems. The class name should be Math_BigInteger, all of the defines should be MATH_BIGINTEGER_FOO, etc.The documentation, while thorough, needs to be in the phpDocumentor format. Also, the header isn't the required PEAR header.

I find it somehow unconstructive (if not destructive) to come up with such things in the vote phase. The proposal has been online for 2 weeks. CS Issues can be fixed in CVS.

The bcpowmod function you define should either be a part of PHPCompat (ie. your package requires PHPCompat, which implements this function) or you should put that if statement into your class definition.

Jim does not have to use PHPCompat, you can if he feels that it will help (I personnally would not use it here).

Ideally, your class would use the native BC functions if they existed as well.

I would rather go directly with an early version (4.3.x for example). It would be nice if further votes (in pepr in general) focus on the goal and implementation of a package before voting -1, especially when all bad points are about CS, inline docs and PHPCompat. It is not possible to go back to comment phase. I suggest to delete it and start a new proposal. Fix the obvious CS issues during the comment phase and then vote again. Jim, is it ok with you? Thanks, --Pierre