Re: [PEPr] +1 for Math::BigInteger

Justin Patrin wrote: > Justin Patrin (http://pear.php.net/user/justinpatrin) has voted +1 on the proposal for > Math::BigInteger. > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=407 > Vote information: > > http://pear.php.net/pepr/pepr-vote-show.php?id=407&handle=justinpatrin > > This vote is conditional. The condition is: > > Follow Coding Standards (CS): > * All constants must be prefixed with the package name. > * Space after commas in function calls > * Space after semicolon in for() > * Space before and after all operators (*, +, -, /, etc) > * Follow all other CS rules > > Comments about a function should be in the docblock, not in // before the docblock. > > All parameters in docblocks need a description. > > All return values need an english description (see divide()). > > No need to check class in every function. (Just don't check at all.) > > Class/package name should be Math_BigInteger. > > Native bc functions should be used if present (if possible). > > Private functions need full docblocks too. > Does this package play well with existing Math_Integer package? Since Math_Integer is doing the BC/GMP detection, plugging this Math_BigInteger as a driver backend to Math_Integer *may* make sense. This package is really a fallback if either BC or GMP are not present, because doing big int computations in pure PHP is really too slow for most applications. -Philippe