[PEPr] Comment on Networking::Net_CheckMAC
| From: | Graham Christensen | Date: | Wed, 25 Oct 2006 23:58:59 +0000 |
| Subject: | [PEPr] Comment on Networking::Net_CheckMAC | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-44752@lists.php.net to get a copy of this message | ||
Graham Christensen (http://pear.php.net/user/itrebal) has commented on the proposal for
Networking::Net_CheckMAC.
Comment:
($uppercase) ? $macaddr = strtoupper($macaddr) : $macaddr =
strtolower($macaddr);
Either switch that to an if-else statement, or do:
$macaddr = ($uppercase)?strtoupper($macaddr):strtolower($macaddr);
Much cleaner and easier to read.
Note: Ternaries are generally avoided.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=454
--
Sent by PEPr, the automatic proposal system at http://pear.php.net