[PEPr] Comment on Networking::Net_CheckMAC

Justin Patrin (http://pear.php.net/user/justinpatrin) has commented on the proposal for Networking::Net_CheckMAC. Comment: As Graham mentioned, ($uppercase) ? $macaddr = strtoupper($macaddr) : $macaddr = strtolower($macaddr); should be $macaddr = ($uppercase) ? strtoupper($macaddr) : strtolower($macaddr); I'd rather you used ' and . for your strings instead of " to keep consistency (and for readability). Why replace any non-ok chars at the beginning? Shouldn't any string that has these chars fail as it's not an ok MAC? Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=454 -- Sent by PEPr, the automatic proposal system at http://pear.php.net