[PEPr] Comment on Web Services::Services_ProjectHoneyPot

Mark Wiesemann (http://pear.php.net/user/wiesemann) has commented on the proposal for Web Services::Services_ProjectHoneyPot. Comment: Here is my short review (in addition to the comments on the mailing list): - some CS issues: * s/Pear_Exception/PEAR_Exception/ * comments for class properties are missing * if/switch are still wrong (no linebreak before "{") * no space before the opening parenthesis in "throw new Services_ProjectHoneyPot_Exception (" please, same for "function ... (" - sprintf() isn't really fast and I would consider rewriting a line like $ip_query = sprintf('%s.%s', $ip, $this->accesskey); to $ip_query = $ip . '.' . $this->accesskey; - comment for parseReponse() contains "Pear_Error" Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=480 -- Sent by PEPr, the automatic proposal system at http://pear.php.net