[PEPr] Comment on Web Services::Services_ProjectHoneyPot

From: Date: Mon, 30 Apr 2007 13:57:33 +0000
Subject: [PEPr] Comment on Web Services::Services_ProjectHoneyPot
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-46507@lists.php.net to get a copy of this message
Graham Christensen (http://pear.php.net/user/itrebal) has commented on the proposal for Web Services::Services_ProjectHoneyPot. Comment: Minor discrepancy, but the variable $blacklist is poorly named. At first glance I thought it was a literal blacklisted host, which is confusing. I recommend changing it to honeypotHost or something that explains what it actually is. Mark's comment about class properties would also fix this, but properly named variables goes a long way to being easily maintainable. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=480 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#46507) next »