Re: [PEPr] +1 for Web Services::Services_ProjectHoneyPot

Dearest Christian! ;-) On 16 Feb 2008 07:16:46 -0000, Christian Weiske <cweiske@php.net> wrote: > (...) > - The response object is very unclear. You don't describe it's structure and just > link to some api page. I added more details for the array response in the docblock. The object type is returns Services_ProjectHoneyPot_Response_Result: <http://code.google.com/p/services-projecthoneypot/source/browse/trunk/Services/ProjectHoneyPot/Response/Result.php> > - $response = new stdClass(); does not help anyone and is also wrong, since parseResponse() > says it returns an array. This is also fixed. Thanks. > You should return a response object with helper methods like getType(), isSearchEngine(), > isSpammer() and such. That's an interesting idea, though I would personally would call it over-engineered but I am trying to make everyone happy here. ;-) The object response was rather "optional" (at first), now it's evolved and I see it to be more comprehensive than a plain array even though a plain array also has its advantages. Anyway, as I said above, I implemented Services_ProjectHoneyPot_Response_Result to address your feedback, so please check SVN for my "proposal" and let me know if that works for you: <http://code.google.com/p/services-projecthoneypot/source/browse/trunk/Services/ProjectHoneyPot/Response/Result.php> Thanks for your feedback! Have a great weekend! Till