[PEPr] +1 for Web Services::Services_ProjectHoneyPot

From: Date: Sat, 16 Feb 2008 07:16:46 +0000
Subject: [PEPr] +1 for Web Services::Services_ProjectHoneyPot
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-49166@lists.php.net to get a copy of this message
Christian Weiske (http://pear.php.net/user/cweiske) has voted +1 on the proposal for Web Services::Services_ProjectHoneyPot. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=480 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=480&handle=cweiske This vote is conditional. The condition is: The package seems to be helpful, and it's great to see that now we're having 2 anti-spam packages. What I didn't like though: - Class variables are not documented. They have docblocks, but you don't tell us what they actually /mean/. - The response object is very unclear. You don't describe it's structure and just link to some api page. - $response = new stdClass(); does not help anyone and is also wrong, since parseResponse() says it returns an array. You should return a response object with helper methods like getType(), isSearchEngine(), isSpammer() and such. -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#49166) next »