[PEPr] Comment on Encryption::Crypt_DiffieHellman

Pádraic Brady (http://pear.php.net/user/padraic) has commented on the proposal for Encryption::Crypt_DiffieHellman. Comment: Hi Phillipe, - I'll update the docblock here: the method allows for integers so ctype_digit() would not work without adding a further type check so integers are never passed to it. I can do this if needed. - Constructor @return removed. Never thought about this - I'll remember it for the future. - Would prefer to avoid a static method here unless it offers a clear advantage. - Will check into - the Math area is a temporary set of classes. - I'll see about adding a factory method. Probably best to link it across setBigIntegerMath() which I left public for a similar reason. - The CS breach will be hunted down and duly squished beneath mine heel, yar! - Not a clue why to change here (and not being sarcastic). I stopped measuring things in microseconds years ago for PHP. The entire Diffie-Hellman run probably outweighs such tiny things by a wide margin. Is it a lot slower? Was it a performance comment even? Thanks for the feedback! Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=496 -- Sent by PEPr, the automatic proposal system at http://pear.php.net