[PEPr] +1 for Encryption::Crypt_DiffieHellman
| From: | Brett Bieber | Date: | Mon, 02 Jul 2007 17:31:47 +0000 |
| Subject: | [PEPr] +1 for Encryption::Crypt_DiffieHellman | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-47144@lists.php.net to get a copy of this message | ||
Brett Bieber (http://pear.php.net/user/saltybeagle) has voted +1 on the proposal for
Encryption::Crypt_DiffieHellman.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=496
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=496&handle=saltybeagle
Comment:
Excellent inline documentation... minor issues,
PHP Fatal error: Class 'Crypt_DiffieHellman_BigInteger' not found in
/Users/bbieber/Desktop/Crypt_DiffieHellman-0.1.0a2/Crypt_DiffieHellman-0.1.0a2/DiffieHellman.php
on line 380
Should be Crypt_DiffieHellman_Math_BigInteger
And on the tests -
1) testDiffieWithSpec(Crypt_DiffieHellmanTest)
Object of class Crypt_DiffieHellman could not be converted to string
/Users/bbieber/Desktop/Crypt_DiffieHellman-0.1.0a2/Crypt_DiffieHellman-0.1.0a2/tests/DiffieHellmanTest.php:34
I'm confident all will be cleared up, great work.
--
Sent by PEPr, the automatic proposal system at http://pear.php.net