[PEPr] Comment on Web Services::Services_TinyURL
| From: | Travis Swicegood | Date: | Tue, 11 Sep 2007 12:28:52 +0000 |
| Subject: | [PEPr] Comment on Web Services::Services_TinyURL | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-47972@lists.php.net to get a copy of this message | ||
Travis Swicegood (http://pear.php.net/user/tswicegood) has commented on the proposal for Web
Services::Services_TinyURL.
Comment:
Couple of thoughts:
1) What about those of us who like to instantiate everything? :-) Would a
Services_TinyURL::singleton/getInstance() be appropriate, or am I the only
one that would want to instantiate this object?
2) I think there's a typo on the pattern of the first preg_match() of
lookup(). "[a-z0-91]" - the "1" is redundant, no?
3) Why use preg_match_all() at the end of lookup()?
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=505
--
Sent by PEPr, the automatic proposal system at http://pear.php.net