Re: [PEPr] Comment on Web Services::Services_TinyURL

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

1) What about those of us who like to instantiate everything? :-) Would a Services_TinyURL::singleton/getInstance() be appropriate, or am I the only one that would want to instantiate this object?

I can't think of a strong argument to do so. Can you? I meant for it to be exceptionally lightweight (much like TinyURL itself). I can be persuaded though as I don't feel strongly on the subject. Anyone else feel it should be instantiable (is that a word?)?

2) I think there's a typo on the pattern of the first preg_match() of lookup(). "[a-z0-91]" - the "1" is redundant, no?

Good catch.

3) Why use preg_match_all() at the end of lookup()?

A lack of sleep and coffee? :) Good catch! Thanks! - --Joe -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFG5qBxh0MUGpYY9OQRAgxuAJwPP7XeE2Vv6b6bTX0sBVi0dhH36wCgsder tOY/fsbab74ZWKtn7VyGY8g= =7tjp -----END PGP SIGNATURE-----