Re: Re: [PEPr] Comment on Tools and Utilities::DbDeploy

On Tue, Sep 18, 2007 at 09:30:49AM -0500, Luke Crouch wrote: > I made just about all the suggested changes. The package is now DB_Deploy > and the directories and classes are changed to match PEAR conventions. I > also changed the code formatting as indicated, and tidied up the SQL concat > lines. > > I'm not sure how to add a link to the svn on the proposal ... I don't see an > "Edit" button anymore. so here's a link to the svn @ SF: > > http://peardbdeploy.svn.sourceforge.net/viewvc/peardbdeploy/ > youŕ code is *not* compliant with PEAR Coding Standards: kguest:~/Desktop$ phpcs --report=summary BuildDbDeployPEARPackageTask.php PHP CODE SNIFFER REPORT SUMMARY -------------------------------------------------------------------------------- FILE ERRORS WARNINGS -------------------------------------------------------------------------------- /home/kguest/Desktop/BuildDbDeployPEARPackageTask.php 237 19 -------------------------------------------------------------------------------- A TOTAL OF 237 ERROR(S) AND 19 WARNING(S) WERE FOUND IN 1 FILE(S) -------------------------------------------------------------------------------- This was revision 15 of said file. You would do well to install and use PHP_CodeSniffer to find and take care of such errors. hope this helps, k. -- Ken Guest Mobile: +353 86 8252 141 http://blogs.linux.ie/kenguest/ Irish PHP Users Group http://www.php.ie