Re: Re: [PEPr] Comment on Tools and Utilities::DbDeploy

Okay, I made a bunch of the code-cleanups so there are only a few warnings left... $ phpcs --report=summary ./ PHP CODE SNIFFER REPORT SUMMARY -------------------------------------------------------------------------------- FILE ERRORS WARNINGS -------------------------------------------------------------------------------- ...aces/DefaultWorkspace/dbdeploy/DB/Deploy/Syntax/Factory.php 0 1 ...spaces/DefaultWorkspace/dbdeploy/DB/Deploy/Syntax/MSSQL.php 0 1 ...spaces/DefaultWorkspace/dbdeploy/DB/Deploy/Syntax/MYSQL.php 0 1 ...paces/DefaultWorkspace/dbdeploy/DB/Deploy/Syntax/SQLITE.php 0 1 ...d/workspaces/DefaultWorkspace/dbdeploy/DB/Deploy/Syntax.php 0 1 ...uch/Zend/workspaces/DefaultWorkspace/dbdeploy/DB/Deploy.php 0 20 -------------------------------------------------------------------------------- A TOTAL OF 0 ERROR(S) AND 25 WARNING(S) WERE FOUND IN 6 FILE(S) -------------------------------------------------------------------------------- I don't feel too bad about them seeing how even the stable (1.7.6) PEAR::DB itself has 69 errors & 19 warnings in the DB.php file alone. -L On 9/18/07, till <klimpong@gmail.com> wrote: > > Hey Luke, > > On 9/18/07, Luke Crouch <luke.crouch@gmail.com> wrote: > > I'm mainly thinking about that monster php class that helps me build the > > package.xml file. I borrowed it straight from phing and I really don't > know > > think I know enough to go thru and clean it all up very effectively or > > efficiently. > > > > I'll make sure the files in the package itself are up to snuff. > > That was a mis-understanding, sorry. > > I think if you use helper code which is *not* included in the final > package, no one cares. People just care about whatever is released in > the package file later on. So I guess your helper-class/-script will > not be part of it. > > Till >