Re: Re: [PEPr] Comment on Tools and Utilities::DbDeploy

I'm mainly thinking about that monster php class that helps me build the package.xml file. I borrowed it straight from phing and I really don't know think I know enough to go thru and clean it all up very effectively or efficiently. I'll make sure the files in the package itself are up to snuff. -L On 9/18/07, Ken Guest <kguest@php.net> wrote: > > On Tue, Sep 18, 2007 at 10:17:49AM -0500, Luke Crouch wrote: > > ah, will do. > > > > there are lots of files in the source tree that don't go into the > package > > itself, though. I don't need to PHP_CodeSniff those, do I? > > > > that depends in a way, I think. Certainly I'd try to ensure code going > into the > package itself adheres to some Standard. > > Whether this should extend to, say .phpt test files, is open to personal > discretion I think. I don't know what the PEAR "party line"/opinion on > this is. > > k. > > -- > Ken Guest > Mobile: +353 86 8252 141 http://blogs.linux.ie/kenguest/ > Irish PHP Users Group http://www.php.ie > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.2.2 (GNU/Linux) > > iD8DBQFG7/DCigdNTD9+4fIRAj8lAKCNJRBgYq72a42VHaxx5qdnyaEyOACglAB7 > q2mrFO9/k/tlo0Ztm9ggVtk= > =kqqo > -----END PGP SIGNATURE----- > >