[PEPr] Comment on Networking::URI_Template
| From: | Philippe Jausions | Date: | Mon, 07 Jan 2008 17:33:41 +0000 |
| Subject: | [PEPr] Comment on Networking::URI_Template | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-48899@lists.php.net to get a copy of this message | ||
Philippe Jausions (http://pear.php.net/user/jausions) has commented on the proposal for
Networking::URI_Template.
Comment:
- Why simply not use preg_replace_callback() instead of preg_split() /
rebuilding the string?
- The declaration of $this->template is missing
- Protected methods need their docblocks
- " { " goes on the following line in the function <method> ()
declarations
- Use single quotes ' instead of " around static strings
- Break long lines
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=521
--
Sent by PEPr, the automatic proposal system at http://pear.php.net