Re: [PEPr] +1 for Networking::URI_Template

On Mon Jan 14, 2008 at 09:0007AM -0000, Michel Corne wrote: > - Tests run fine though I had to change *require_once "URI/Template.php"* > to *require_once "File/Template.php"* to get it to run; no big deal > anyway! There was a typo in package.xml which caused the base installation directory to be File/ instead of URI/. I fixed this in the latest revision in Subversion, but the .tgz file still contains the error. > - The package is registered in the Networking category but installs in > File, which I guess is a no brainer if it is to remain in File; disregard > the comment then :-) See above. This was entirely by mistake. > - Shouldn't the class be renamed File_UriTemplate and the file > UriTemplate.php or something like that to reflect the directory structure? > Or more accurately File_UriTemplateParser and UriTemplateParser.php which > is really what it is as you call it ourself? Again see above :-). The class has nothing to do with file handling and thus I think the current name is just fine. > - The file and class doc blocks are missing tags I know. I will get around to bring it up-to-date to the latest Coding Standards before the first release. > - Some function (though protected) are missing documentation. This is again already fixed in Subversion. Thanks for your comments. - Martin