[PEPr] Comment on Networking::URI_Template

From: Date: Mon, 07 Jan 2008 21:53:12 +0000
Subject: [PEPr] Comment on Networking::URI_Template
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-48903@lists.php.net to get a copy of this message
Martin Jansen (http://pear.php.net/user/mj) has commented on the proposal for Networking::URI_Template. Comment: > - Why simply not use preg_replace_callback() instead of preg_split() / rebuilding the string? I promise to look into this. > - The declaration of $this->template is missing Fixed. > - Protected methods need their docblocks Actually I decided to make the protected methods without docblocks private, but added documentation anyway. > - " { " goes on the following line in the function <method> () declarations Fixed. > - Use single quotes ' instead of " around static strings I still don't get why people like this ;-), but have changed it because there seems to be a general consensus in PEAR that this is the way to go. > - Break long lines Fixed. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=521 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#48903) next »