[PEPr] +1 for Networking::URI_Template

From: Date: Mon, 14 Jan 2008 09:00:07 +0000
Subject: [PEPr] +1 for Networking::URI_Template
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-48929@lists.php.net to get a copy of this message
Michel Corne (http://pear.php.net/user/mcorne) has voted +1 on the proposal for Networking::URI_Template. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=521 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=521&handle=mcorne Comment: Sounds good. Did not have a chance to comment during the proposal phase. Will do it now. This is just a few QA related comments: - Tests run fine though I had to change *require_once "URI/Template.php"* to *require_once "File/Template.php"* to get it to run; no big deal anyway! - The package is registered in the Networking category but installs in File, which I guess is a no brainer if it is to remain in File; disregard the comment then :-) - Shouldn't the class be renamed File_UriTemplate and the file UriTemplate.php or something like that to reflect the directory structure? Or more accurately File_UriTemplateParser and UriTemplateParser.php which is really what it is as you call it ourself? - The file and class doc blocks are missing tags - Some function (though protected) are missing documentation. -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#48929) next »