Re: [PEPr] Comment on Networking::Net_Nmap
| From: | Luca Corbo | Date: | Wed, 12 Mar 2008 14:21:12 +0000 |
| Subject: | Re: [PEPr] Comment on Networking::Net_Nmap | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-49404@lists.php.net to get a copy of this message | ||
> Class hierarchy looks good. I like the usage of that __get() and _set(),
> now that I actually see how you're using it (for touching keys in your
> private array, rather than touching actual private variables... I had
> previously assumed it was private variables).
ooops you're right, sorry for the misleading code in the past mail :-)
One typo I see in _Service's
> $_properties initialization is that the 'product' key is listed three
> times.
Fixed ;-)
Last thought would be that if this is indeed PHP5-only, how feasible is it
> to replace the PEAR_Error usage with PEAR_Exception?
Ok, I'm going to look into that.