[PEPr] +1 for Networking::Net_Nmap

From: Date: Mon, 17 Mar 2008 11:10:20 +0000
Subject: [PEPr] +1 for Networking::Net_Nmap
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-49437@lists.php.net to get a copy of this message
Christian Weiske (http://pear.php.net/user/cweiske) has voted +1 on the proposal for Networking::Net_Nmap. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=539 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=539&handle=cweiske This vote is conditional. The condition is: - I don't understand why $host->os() is a function while $host->status is not. That should be consistent. (or rename os() to getOs()). - $services->count() - if you already have an arrayiterator, you can use count($services) directly. Same for rewind() in the examples. - You should use System::which() to find the nmap binary instead of hardcoding the path into the class. - In Parser.php you should add a link to the nmap xml format docs - The parser (and the other classes, too) should definitely be unit-tested - You cannot set delete_output_file via the options - The package does not work on windows (XML Parser error, no temp file generated) (yes, there is a windows version of nmap) -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#49437) next »