[PEPr] Comment on Networking::Net_Nmap

From: Date: Wed, 12 Mar 2008 13:34:12 +0000
Subject: [PEPr] Comment on Networking::Net_Nmap
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-49397@lists.php.net to get a copy of this message
Chuck Burgess (http://pear.php.net/user/ashnazg) has commented on the proposal for Networking::Net_Nmap. Comment: Class hierarchy looks good. I like the usage of that __get() and _set(), now that I actually see how you're using it (for touching keys in your private array, rather than touching actual private variables... I had previously assumed it was private variables). One typo I see in _Service's $_properties initialization is that the 'product' key is listed three times. CS-wise, your current code looks quite clean :) Last thought would be that if this is indeed PHP5-only, how feasible is it to replace the PEAR_Error usage with PEAR_Exception? Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=539 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#49397) next »