Re: [PEPr] +1 for Networking::Net_Nmap

Hi Till, thanks for your comments ! 1) It would be nice if you used visibility in all of your code (and not just > in phpdoc). Sometimes you did make use of it, sometimes not. No idea why. > ;-) You are right ;-) 2) Is there a reason why you always trigger_error() in your parser instead > of using an exception? If not, I'd like to see exceptions. If this is > absolutely necessary, let me know and consider it to be unconditonal. I've missed to replace it in the Service object after last code review :-), I'm going to do it. 3) I'd like to see all get'ers prefixed with get, e.g. Net_Nmap_Host::os() > -> Net_Nmap_Host::getOs(), etc.. Ok, I'm going to change also the access method for the status properties using get and set methods as suggested by Christian 4) Not conditional, more a suggestion - replace is_null($foo) with $foo === > null (those calls are less expensive). > Ok.