Re: [PEPr] 0 for PHP::PHP_ArrayOf
| From: | Michael Gauthier | Date: | Fri, 25 Apr 2008 02:03:48 +0000 |
| Subject: | Re: [PEPr] 0 for PHP::PHP_ArrayOf | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-49892@lists.php.net to get a copy of this message | ||
As far as I know, the @license and @author tags are required for all
classes, including exceptions in PEAR.
On Fri, 2008-25-04 at 00:48 +0000, Alan Knowles wrote:
> Alan Knowles (http://pear.php.net/user/alan_k) has voted 0 on the proposal for
> PHP::PHP_ArrayOf.
>
> Proposal information:
> http://pear.php.net/pepr/pepr-proposal-show.php?id=518
> Vote information:
>
> http://pear.php.net/pepr/pepr-vote-show.php?id=518&handle=alan_k
>
> Comment:
>
> I'm a bit perplexed about what use this package is,
>
> - adding contraint's that throw exceptions / errors when adding to arrays,
> appears to be just hiding code, and supprising coders.. - (I would probably
> be pissed if I had to edit someone's code who had used this).
>
> Anyway.
> General Comments
> - Exception file looks very cluttered. All that @licence, @author on each
> class is a huge overkill?
> - Not sure the name 'ArrayOf' really defines what the class is supposed to
> do, or it's purpose. - (It's purpose being a little unclear...)
>
> I'm tempted to -1 it.. but not so aggreesive in my old age ;)
>
> --
> Sent by PEPr, the automatic proposal system at
> http://pear.php.net
>