[PEPr] +1 for PHP::PHP_ArrayOf
| From: | Markus Tacker | Date: | Fri, 25 Apr 2008 15:31:20 +0000 |
| Subject: | [PEPr] +1 for PHP::PHP_ArrayOf | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-49897@lists.php.net to get a copy of this message | ||
Markus Tacker (http://pear.php.net/user/tacker) has voted +1 on the proposal for PHP::PHP_ArrayOf.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=518
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=518&handle=tacker
This vote is conditional. The condition is:
Looks good to me.
Conditions are:
- Fix license link (see http://pear.php.net/pepr/pepr-vote-show.php?id=518&handle=till)
- remove underscore from private method PHP_ArrayOf::_verifyArray()
- add public keyword to all methods (missing in PHP_ArrayOf::merge())
- put every exception in it's own file
--
Sent by PEPr, the automatic proposal system at http://pear.php.net