Re: [PEPr] +1 for PHP::PHP_ArrayOf

Markus Tacker wrote: > Markus Tacker (http://pear.php.net/user/tacker) has voted +1 on the proposal for > PHP::PHP_ArrayOf. > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=518 > Vote information: > > http://pear.php.net/pepr/pepr-vote-show.php?id=518&handle=tacker > > This vote is conditional. The condition is: > > Looks good to me. > > Conditions are: > - Fix license link (see > http://pear.php.net/pepr/pepr-vote-show.php?id=518&handle=till) > Sure. Will do. > - remove underscore from private method PHP_ArrayOf::_verifyArray() > Quite the opposite, I should actually prepend _ to the private members $iterator and $iteratorClass. See http://pear.php.net/pepr/pepr-proposal-show.php?id=99 "Private members will still be prefixed." > - add public keyword to all methods (missing in PHP_ArrayOf::merge()) > Thanks, will fix. > - put every exception in it's own file Sure, I could do this. Is this the general consensus? I thought exceptions were the exception to the rule of class <-> file, but I certainly see the pros and cons here. -Philippe