Re: [PEPr] Comment on Networking::Net_GPS

Hi, Till Thank you for check! And I changed the comments to the BSD style. Thanks, 2008/5/18, till <klimpong@gmail.com>: > Hey, > > looks good to me, you should also change the class comments to reflect > the new license. I don't think that license@php.net sends out the New > BSD License. For an example, check: > > > <http://cvs.php.net/viewvc.cgi/pear/Mail_Queue/Queue.php?revision=1.30&view=markup> > > Also run PHP_CodeSniffer on the code. ;-) > > To the name question, I think it should be Net_GPS_JP if this is only > implemented in Japan, but maybe others know more about this. > > Till > > > On Sun, May 18, 2008 at 8:20 AM, Horikita Kei <gps4mobile@gmail.com> wrote: > > Hi, Till > > > > Thank you for helping and advices. > > > > I changed my code for extensible per provider. > > So I do not think that a 'JP' category is necessary. > > How do you think? > > > > And sorry, I could not examine about concrete code for GPS in foreign country. > > > > Please give me opinions for the name, everybody. > > > > Thanks > > > > 2008/5/6, till <klimpong@gmail.com>: > >> On Tue, May 6, 2008 at 9:15 AM, Horikita Kei <gps4mobile@gmail.com> wrote: > >> > (...) > >> > > - The name of the package "Net_GPS" ... > >> > > >> > - I do not persist in a name,,but there is not good ideas. "HTML_GPS" > >> > or > >> > "Net_Mobile_GPS"? > >> > > >> > please give me advice, everybody. > >> > >> Hey there, > >> > >> I've never seen this kind of thing, so maybe it should include "JP" in > >> the name if it is so specific to Japan? Just a thought though! It > >> looks pretty interesting, do you know if carriers/providers outside > >> your country make use of such things? > >> > >> Thanks, > >> Till > >> >