[PEPr] +1 for Networking::Net_GPS

From: Date: Fri, 30 May 2008 14:20:28 +0000
Subject: [PEPr] +1 for Networking::Net_GPS
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-50199@lists.php.net to get a copy of this message
Michael Gauthier (http://pear.php.net/user/gauthierm) has voted +1 on the proposal for Networking::Net_GPS. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=552 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=552&handle=gauthierm This vote is conditional. The condition is: Cool package. I didn't even know mobile devices supported this behavior. Some comments: * When documenting member variables, '@var object' should be '@var Net_UserAgent_Mobile' * The method getGPSLink() could use more documentation. From what I can tell, this is how you display a link that would send GPS information from the phone when clicked. * I'd like to see the interface Net_GPS_ProviderInterface in a separate file. * Document thrown exceptions with @throws tag. * check class_exists() before instantiating a driver. * make sure class name doesn't contain directories ('../FooBar' for example) before including driver file. * Perhaps an abstract class rather than an interface would be appropriate for Net_GPS_Provider. The Constructor seems to be copied four times. * I agree with David about the package name. -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#50199) next »